rafaelweingartner commented on a change in pull request #2315: A comprehensive
solution for #CLOUDSTACK-9025.
URL: https://github.com/apache/cloudstack/pull/2315#discussion_r150218941
##########
File path: engine/schema/src/com/cloud/host/dao/HostDaoImpl.java
##########
@@ -792,11 +791,8 @@ public void loadHostTags(HostVO host) {
@Override
public List<HostVO> findLostHosts(long timeout) {
List<HostVO> result = new ArrayList<HostVO>();
- String sql =
- "select h.id from host h left join cluster c on
h.cluster_id=c.id where h.mgmt_server_id is not null and h.last_ping < ? and
h.status in ('Up', 'Updating', 'Disconnected', 'Connecting') and h.type not in
('ExternalFirewall', 'ExternalLoadBalancer', 'TrafficMonitor',
'SecondaryStorage', 'LocalSecondaryStorage', 'L2Networking') and (h.cluster_id
is null or c.managed_state = 'Managed') ;";
- try (
- TransactionLegacy txn = TransactionLegacy.currentTxn();
- PreparedStatement pstmt = txn.prepareStatement(sql);) {
+ String sql = "select h.id from host h left join cluster c on
h.cluster_id=c.id where h.mgmt_server_id is not null and h.last_ping < ? and
h.status in ('Up', 'Updating', 'Disconnected', 'Connecting') and h.type not in
('ExternalFirewall', 'ExternalLoadBalancer', 'TrafficMonitor',
'SecondaryStorage', 'LocalSecondaryStorage', 'L2Networking') and (h.cluster_id
is null or c.managed_state = 'Managed') ;";
Review comment:
You mean, to break into multiple lines?
I actually did not notice this, probably I left my save actions applying in
all lines, instead of only modified lines.
Would you like me to change?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
