khos2ow commented on a change in pull request #2365: CLOUDSTACK-10197: Rename
xentools iso for XenServer 7.0+
URL: https://github.com/apache/cloudstack/pull/2365#discussion_r158567995
##########
File path:
plugins/hypervisors/xenserver/src/com/cloud/hypervisor/xenserver/discoverer/XcpServerDiscoverer.java
##########
@@ -529,13 +540,12 @@ public boolean processCommands(long agentId, long seq,
Command[] commands) {
}
private void createXsToolsISO() {
- String isoName = "xs-tools.iso";
- VMTemplateVO tmplt = _tmpltDao.findByTemplateName(isoName);
+ VMTemplateVO tmplt = _tmpltDao.findByTemplateName(_toolsIsoName);
Long id;
if (tmplt == null) {
id = _tmpltDao.getNextInSequence(Long.class, "id");
VMTemplateVO template =
- VMTemplateVO.createPreHostIso(id, isoName, isoName,
ImageFormat.ISO, true, true, TemplateType.PERHOST, null, null, true, 64,
Account.ACCOUNT_ID_SYSTEM,
+ VMTemplateVO.createPreHostIso(id, _toolsIsoName,
_toolsIsoName, ImageFormat.ISO, true, true, TemplateType.PERHOST, null, null,
true, 64, Account.ACCOUNT_ID_SYSTEM,
Review comment:
I, honestly, don't like it and have never used it like this, but wanted to
follow the same pattern in the code base.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
