khos2ow commented on a change in pull request #2365: CLOUDSTACK-10197: Rename
xentools iso for XenServer 7.0+
URL: https://github.com/apache/cloudstack/pull/2365#discussion_r159719752
##########
File path:
plugins/hypervisors/xenserver/src/com/cloud/hypervisor/xenserver/resource/CitrixResourceBase.java
##########
@@ -2630,6 +2631,22 @@ public VDI getIsoVDIByURL(final Connection conn, final
String vmName, final Stri
}
}
+ private String actualIsoTemplate(final Connection conn) throws
BadServerResponse, XenAPIException, XmlRpcException {
Review comment:
I will the documentation, but I really don't think unit testing on this
specific method will be possible. Because it needs a live XenServer Host for
the method to connect to (both `Host.getByUuid(conn, _host.getUuid());` and
`host.getRecord(conn);`) and I'm not sure if they can be Mocked in some way.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
