khos2ow commented on a change in pull request #2365: CLOUDSTACK-10197: Rename
xentools iso for XenServer 7.0+
URL: https://github.com/apache/cloudstack/pull/2365#discussion_r159707625
##########
File path:
plugins/hypervisors/xenserver/src/com/cloud/hypervisor/xenserver/resource/CitrixResourceBase.java
##########
@@ -2592,9 +2592,10 @@ public VDI getIsoVDIByURL(final Connection conn, final
String vmName, final Stri
String mountpoint = null;
if (isoURL.startsWith("xs-tools")) {
Review comment:
Yes it did. I had an idea to change the iso name (url here refers to _name_)
to something general - like `xenserver-tools` and manage the same thing in
`actualIsoTemplate`, but _xs-tools.iso_ is used in some many places (specially
in some test cases) which I ended up not changing this. Potentially it only
needs a wiki/user guide doc only.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
