rafaelweingartner commented on a change in pull request #2146: CLOUDSTACK-4757:
Support OVA files with multiple disks for templates
URL: https://github.com/apache/cloudstack/pull/2146#discussion_r158581827
##########
File path:
engine/storage/image/src/org/apache/cloudstack/storage/image/TemplateServiceImpl.java
##########
@@ -675,6 +695,18 @@ protected Void
createTemplateCallback(AsyncCallbackDispatcher<TemplateServiceImp
return null;
}
+ // Check if OVA contains additional data disks. If yes, create
Datadisk templates for each of the additional datadisk present in the OVA
+ if (template.getFormat().equals(ImageFormat.OVA)) {
+ if (!createDataDiskTemplates(template)) {
Review comment:
is there a way for `createDataDiskTemplates` to return false?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
