rafaelweingartner commented on a change in pull request #2146: CLOUDSTACK-4757:
Support OVA files with multiple disks for templates
URL: https://github.com/apache/cloudstack/pull/2146#discussion_r158581943
##########
File path:
plugins/hypervisors/vmware/src/com/cloud/hypervisor/vmware/resource/VmwareResource.java
##########
@@ -681,9 +683,10 @@ private Answer execute(ResizeVolumeCommand cmd) {
try {
if (newSize < oldSize) {
- throw new Exception("VMware doesn't support shrinking volume
from larger size: " + oldSize/(1024*1024) + " GB to a smaller size: " +
newSize/(1024*1024) + " GB");
+ throw new Exception(
+ "VMware doesn't support shrinking volume from larger
size: " + oldSize / (1024 * 1024) + " GB to a smaller size: " + newSize / (1024
* 1024) + " GB");
} else if (newSize == oldSize) {
- return new ResizeVolumeAnswer(cmd, true, "success",
newSize*1024);
+ return new ResizeVolumeAnswer(cmd, true, "success", newSize *
1024);
Review comment:
More magic numbers
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
