rafaelweingartner commented on a change in pull request #2146: CLOUDSTACK-4757:
Support OVA files with multiple disks for templates
URL: https://github.com/apache/cloudstack/pull/2146#discussion_r158581956
##########
File path:
plugins/hypervisors/vmware/src/com/cloud/hypervisor/vmware/resource/VmwareResource.java
##########
@@ -2314,17 +2307,17 @@ private void tearDownVm(VirtualMachineMO vmMo) throws
Exception{
}
int getReservedMemoryMb(VirtualMachineTO vmSpec) {
- if
(vmSpec.getDetails().get(VMwareGuru.VmwareReserveMemory.key()).equalsIgnoreCase("true"))
{
- return (int) (vmSpec.getMinRam() / (1024 * 1024));
- }
- return 0;
+ if
(vmSpec.getDetails().get(VMwareGuru.VmwareReserveMemory.key()).equalsIgnoreCase("true"))
{
+ return (int)(vmSpec.getMinRam() / (1024 * 1024));
Review comment:
magic nubers
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
