rhtyd commented on a change in pull request #2562: consoleproxy: use consoleproxy.domain for non-ssl enable env URL: https://github.com/apache/cloudstack/pull/2562#discussion_r181354685
########## File path: core/src/com/cloud/info/ConsoleProxyInfo.java ########## @@ -55,6 +57,9 @@ public ConsoleProxyInfo(boolean sslEnabled, String proxyIpAddress, int port, int proxyImageUrl += ":" + this.proxyUrlPort; } else { proxyAddress = proxyIpAddress; + if (!Strings.isNullOrEmpty(consoleProxyUrlDomain)) { Review comment: @rafaelweingartner I'm not sure but last time I checked, the `isNullOrEmpty` did check for emptiness (blank) of string (https://google.github.io/guava/releases/snapshot-jre/api/docs/com/google/common/base/Strings.html#isNullOrEmpty-java.lang.String-) ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services