rhtyd commented on a change in pull request #2562: consoleproxy: use
consoleproxy.domain for non-ssl enable env
URL: https://github.com/apache/cloudstack/pull/2562#discussion_r181360178
##########
File path: server/src/com/cloud/consoleproxy/ConsoleProxyManagerImpl.java
##########
@@ -1246,8 +1246,7 @@ public boolean configure(String name, Map<String,
Object> params) throws Configu
Map<String, String> configs =
_configDao.getConfiguration("management-server", params);
- String value = configs.get(Config.ConsoleProxyCmdPort.key());
- value = configs.get("consoleproxy.sslEnabled");
+ String value = configs.get("consoleproxy.sslEnabled");
if (value != null && value.equalsIgnoreCase("true")) {
Review comment:
@rafaelweingartner I checked this is a string comparison, the 'true' has to
do with the string stored in global setting's value from db. Looks like a
massive cleanup may be needed in this class and others. I'll avoid changes in
that case, keep the changes in PR minimal and maybe send a separate cleanup PR.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
