DaanHoogland commented on a change in pull request #2602: CLOUDSTACK-10365:
Change the "getXXX" boolean-related method names to…
URL: https://github.com/apache/cloudstack/pull/2602#discussion_r184818637
##########
File path: api/src/main/java/com/cloud/offering/ServiceOffering.java
##########
@@ -86,7 +86,7 @@
/**
* @return Does this service plan support Volatile VM that is, discard
VM's root disk and create a new one on reboot?
*/
- boolean getVolatileVm();
+ boolean isVolatileVm();
Review comment:
supportVolitileVMs() would be more pleasing on the human eye. Not that that
should hamper this change but what is the objective? to adhere to another
naming convention or to make better code for reading? and seriously both are
valid motives under circumstances, but I am really wondering.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
