DaanHoogland commented on a change in pull request #2602: CLOUDSTACK-10365:
Change the "getXXX" boolean-related method names to…
URL: https://github.com/apache/cloudstack/pull/2602#discussion_r186479307
##########
File path: api/src/main/java/com/cloud/offering/ServiceOffering.java
##########
@@ -76,7 +76,7 @@
/**
* @return Does this service plan offer HA?
*/
- boolean getOfferHA();
+ boolean isOfferHA();
Review comment:
good point @fmaximus so the generic dao breaks if we go any other way is
your message, is it?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
