rafaelweingartner commented on a change in pull request #2503: Support multiple
volume access groups per compute cluster
URL: https://github.com/apache/cloudstack/pull/2503#discussion_r185146809
##########
File path:
plugins/storage/volume/solidfire/src/main/java/org/apache/cloudstack/storage/datastore/util/SolidFireUtil.java
##########
@@ -300,7 +311,7 @@ public static String getValue(String keyToMatch, String
url, boolean throwExcept
}
public static String getSolidFireAccountName(String csAccountUuid, long
csAccountId) {
- return "CloudStack_" + csAccountUuid + "_" + csAccountId;
+ return SF_CS_ACCOUNT_PREFIX + csAccountUuid + "_" + csAccountId;
Review comment:
That sounds a bit better.
I think that @DaanHoogland mentioned the `get` prefix because we had some
other PRs normalizing the methods used to retrieve POJOs attributes. However,
if `get` is being used as a synonym for `retrieve` that should also work, which
seems to be this case. English is my second language so, I might be (probably
am) mistaken.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
