rafaelweingartner commented on a change in pull request #2503: Support multiple
volume access groups per compute cluster
URL: https://github.com/apache/cloudstack/pull/2503#discussion_r178157458
##########
File path:
plugins/storage/volume/solidfire/src/main/java/org/apache/cloudstack/storage/datastore/util/SolidFireUtil.java
##########
@@ -397,65 +508,290 @@ public static void hostAddedToOrRemovedFromCluster(long
hostId, long clusterId,
}
}
- public static long placeVolumeInVolumeAccessGroup(SolidFireConnection
sfConnection, long sfVolumeId, long storagePoolId,
- String vagUuid,
List<HostVO> hosts, ClusterDetailsDao clusterDetailsDao) {
- if (hosts == null || hosts.isEmpty()) {
- throw new CloudRuntimeException("There must be at least one host
in the cluster.");
+ // Put the host in an existing VAG or create a new one (only create a new
one if all existing VAGs are full (i.e. 64 hosts max per VAG) and if
+ // creating a new VAG won't exceed 4 VAGs for the computer cluster).
+ // If none of the hosts in the cluster are in a VAG, then leave this host
out of a VAG.
+ // Place applicable volume IDs in VAG, if need be (account of volume
starts with SF_CS_ACCOUNT_PREFIX).
+ private static void handleVagForHost(SolidFireUtil.SolidFireConnection
sfConnection, List<SolidFireUtil.SolidFireVag> sfVags, Host host, HostDao
hostDao) {
Review comment:
You have a clear definition of the difference between Javadocs and java
comments. That is awesome 👍
I asked because I have seen people trying to write documentation, but they
used comment notation instead. If you believe it is ok with Java comment
notation, I am ok with it ;)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
