rafaelweingartner commented on a change in pull request #2503: Support multiple
volume access groups per compute cluster
URL: https://github.com/apache/cloudstack/pull/2503#discussion_r178154409
##########
File path:
plugins/hypervisors/vmware/src/main/java/com/cloud/storage/resource/VmwareStorageProcessor.java
##########
@@ -2956,6 +3033,61 @@ public void handleTargets(boolean add,
ModifyTargetsCommand.TargetTypeToRemove t
}
}
+ private String waitForDatastoreName(HostDatastoreSystemMO
hostDatastoreSystemMO, String iqn) throws Exception {
+ long secondsToWait = 120;
Review comment:
Got it. Thanks for the explanation.
I agree that we do not need to externalize this value here; I only asked
because the "constant" 120 was in a variable, and not directly in the code
where it is used. I liked it though, it gave meaning to that magic number.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
