wido commented on a change in pull request #2829: CLOUDSTACK-9473: storage pool
capacity check when volume is resized or migrated
URL: https://github.com/apache/cloudstack/pull/2829#discussion_r213967984
##########
File path: server/src/com/cloud/storage/StorageManagerImpl.java
##########
@@ -1830,12 +1830,37 @@ public boolean storagePoolHasEnoughSpace(List<Volume>
volumes, StoragePool pool,
}
}
+ return checkPoolforSpace(pool, allocatedSizeWithTemplate,
totalAskingSize);
+ }
+
+ @Override
+ public boolean storagePoolHasEnoughSpaceForResize(StoragePool pool, long
currentSize, long newSiz) {
+ if (!checkUsagedSpace(pool)) {
+ return false;
+ }
+ if (s_logger.isDebugEnabled()) {
Review comment:
Is this if really needed? Can't you just log to debug and let the filter of
log4j handle it?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
