rhtyd commented on a change in pull request #2829: CLOUDSTACK-9473: storage
pool capacity check when volume is resized or migrated
URL: https://github.com/apache/cloudstack/pull/2829#discussion_r213969945
##########
File path: server/src/com/cloud/storage/StorageManagerImpl.java
##########
@@ -1830,12 +1830,37 @@ public boolean storagePoolHasEnoughSpace(List<Volume>
volumes, StoragePool pool,
}
}
+ return checkPoolforSpace(pool, allocatedSizeWithTemplate,
totalAskingSize);
+ }
+
+ @Override
+ public boolean storagePoolHasEnoughSpaceForResize(StoragePool pool, long
currentSize, long newSiz) {
+ if (!checkUsagedSpace(pool)) {
+ return false;
+ }
+ if (s_logger.isDebugEnabled()) {
Review comment:
If log4j does not have debug enabled, then the string concat operation will
still be performed by the JVM only when the string is passed to the `debug()`
method it will be ignored. So, it depends if we can afford the CPU/time spent
on the operation.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
