rafaelweingartner commented on a change in pull request #2829: CLOUDSTACK-9473:
storage pool capacity check when volume is resized or migrated
URL: https://github.com/apache/cloudstack/pull/2829#discussion_r213986680
##########
File path: server/src/com/cloud/storage/StorageManagerImpl.java
##########
@@ -1847,21 +1872,26 @@ public boolean storagePoolHasEnoughSpace(List<Volume>
volumes, StoragePool pool,
s_logger.debug("Total capacity of the pool " + poolVO.getName() + "
with ID " + pool.getId() + " is " + totalOverProvCapacity);
double storageAllocatedThreshold =
CapacityManager.StorageAllocatedCapacityDisableThreshold.valueIn(pool.getDataCenterId());
-
- s_logger.debug("Checking pool: " + pool.getId() + " for volume
allocation " + volumes.toString() + ", maxSize : " + totalOverProvCapacity + ",
totalAllocatedSize : "
- + allocatedSizeWithTemplate + ", askingSize : " +
totalAskingSize + ", allocated disable threshold: " +
storageAllocatedThreshold);
+ if (s_logger.isDebugEnabled()) {
Review comment:
Why checking before logging?
We are removing this from other places. Let's remove conditionals from our
code base.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
