rafaelweingartner commented on a change in pull request #2829: CLOUDSTACK-9473:
storage pool capacity check when volume is resized or migrated
URL: https://github.com/apache/cloudstack/pull/2829#discussion_r214514149
##########
File path: server/src/com/cloud/storage/VolumeApiServiceImpl.java
##########
@@ -1137,6 +1137,14 @@ private VolumeVO orchestrateResizeVolume(long volumeId,
long currentSize, long n
UserVmVO userVm = _userVmDao.findById(volume.getInstanceId());
StoragePoolVO storagePool =
_storagePoolDao.findById(volume.getPoolId());
boolean isManaged = storagePool.isManaged();
+
+ List<Volume> volumes = new ArrayList<Volume>();
Review comment:
My brain only works with up to 10 lines of code methods. Anything else is
just a blur.
I think the code is ok; we just need to check if this variable is used; if
it is not, please remove it.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
