borisstoyanov commented on a change in pull request #2869: Fix some Marvin
smoke tests
URL: https://github.com/apache/cloudstack/pull/2869#discussion_r221846841
##########
File path: test/integration/smoke/test_vm_life_cycle.py
##########
@@ -839,6 +839,7 @@ def setUpClass(cls):
@classmethod
def tearDownClass(cls):
+ time.sleep(120)
Review comment:
I'm not a fan of implicit waits, there must be a reason to put here and
there 2min wait, let's try to convert these waits to explicit style and wait
for the particular condition than just some bond of time. Let me know per each
individual sleep what you're after and we could define a method to chase it.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
