borisstoyanov commented on a change in pull request #2869: Fix some Marvin
smoke tests
URL: https://github.com/apache/cloudstack/pull/2869#discussion_r221850181
##########
File path: test/integration/smoke/test_deploy_virtio_scsi_vm.py
##########
@@ -96,6 +96,7 @@ def setUpClass(cls):
cls.zone = get_zone(cls.apiclient, testClient.getZoneForTests())
cls.pod = get_pod(cls.apiclient, cls.zone.id)
cls.services['mode'] = cls.zone.networktype
+ cls.cleanup = []
Review comment:
had another look at the code, I think the problem is in that 'if' hypervisor
check, see at the end of it there's a return, which will end the execution of
this method and that's why we don't get the cleanup defined. See the issue is
that instead of return we should have skip(), which will 'cancel' the test
execution as it is. let me help with that
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
