rafaelweingartner commented on a change in pull request #2848: Vmware offline
migration
URL: https://github.com/apache/cloudstack/pull/2848#discussion_r237218861
##########
File path:
engine/orchestration/src/main/java/com/cloud/vm/VirtualMachineManagerImpl.java
##########
@@ -1976,92 +1965,244 @@ public void storageMigration(final String vmUuid,
final StoragePool destPool) {
private void orchestrateStorageMigration(final String vmUuid, final
StoragePool destPool) {
final VMInstanceVO vm = _vmDao.findByUuid(vmUuid);
+ preStorageMigrationStateCheck(destPool, vm);
+
+ try {
+ if(s_logger.isDebugEnabled()) {
Review comment:
@mike-tutkowski the current log4j we use does not allow that. However,
log4j-2 does. I am trying to make time to finish the upgrade.
@dhlaluku even though I think that using the check
`s_logger.isDebugEnabled()` is foolish in our context, you do not need to
remove just because of me. I understand @DaanHoogland perspective.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
