rafaelweingartner commented on a change in pull request #2848: Vmware offline
migration
URL: https://github.com/apache/cloudstack/pull/2848#discussion_r237216601
##########
File path:
api/src/main/java/org/apache/cloudstack/api/command/user/volume/MigrateVolumeCmd.java
##########
@@ -120,4 +120,19 @@ public void execute() {
}
}
+ @Override
+ public String getSyncObjType() {
+ if (getSyncObjId() != null) {
+ return BaseAsyncCmd.migrationSyncObject;
+ }
+ return null;
+ }
+
+ @Override
+ public Long getSyncObjId() {
+ if (getStoragePoolId() != null) {
Review comment:
I did not get your explanation. When we extend the class and then override
the method, the whole implementation of `getSyncObjId` is changed. I do not
know how a possible method override can require this code here.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
