rhtyd commented on a change in pull request #3430: Compare VLAN names instead
of expanding to range
URL: https://github.com/apache/cloudstack/pull/3430#discussion_r298037550
##########
File path:
server/src/main/java/com/cloud/configuration/ConfigurationManagerImpl.java
##########
@@ -3542,9 +3541,7 @@ public Vlan createVlanAndPublicIpRange(final long
zoneId, final long networkId,
continue;
}
// from here, subnet overlaps
- if (!UriUtils.checkVlanUriOverlap(
-
BroadcastDomainType.getValue(BroadcastDomainType.fromString(vlanId)),
-
BroadcastDomainType.getValue(BroadcastDomainType.fromString(vlan.getVlanTag()))))
{
+ if (!vlanId.equals(vlan.getVlanTag())) {
Review comment:
I think this may cause an issue, because the vlan.getVlanTag() could be
something like a range 100-200, so if vlanId is 101 the check should be done in
the range. Let me revisit this shortly and check if the overlap check is
necessary or not.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
