rhtyd commented on a change in pull request #3430: Compare VLAN names instead of expanding to range URL: https://github.com/apache/cloudstack/pull/3430#discussion_r298460473
########## File path: server/src/main/java/com/cloud/configuration/ConfigurationManagerImpl.java ########## @@ -3581,9 +3562,29 @@ public Vlan createVlanAndPublicIpRange(final long zoneId, final long networkId, if (!NetUtils.is31PrefixCidr(newCidr)) { if (NetUtils.ipRangesOverlap(startIP, endIP, otherVlanStartIP, otherVlanEndIP)) { throw new InvalidParameterValueException("The IP range already has IPs that overlap with the new range." + - " Please specify a different start IP/end IP."); + " Please specify a different start IP/end IP."); } } + } else { + // For untagged or non-overlapping URIs we need to ensure there is no Public traffic type Review comment: Comment should say 'For tagged or non-overlapping...' this else will be only hit when vlanID is overlapping and is not untagged. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services