rhtyd commented on a change in pull request #3430: Compare VLAN names instead
of expanding to range
URL: https://github.com/apache/cloudstack/pull/3430#discussion_r298038048
##########
File path:
server/src/main/java/com/cloud/configuration/ConfigurationManagerImpl.java
##########
@@ -3542,9 +3541,7 @@ public Vlan createVlanAndPublicIpRange(final long
zoneId, final long networkId,
continue;
}
// from here, subnet overlaps
- if (!UriUtils.checkVlanUriOverlap(
-
BroadcastDomainType.getValue(BroadcastDomainType.fromString(vlanId)),
-
BroadcastDomainType.getValue(BroadcastDomainType.fromString(vlan.getVlanTag()))))
{
+ if (!vlanId.equals(vlan.getVlanTag())) {
Review comment:
Or perhaps if the issue is just for the 'untagged' VLAN, a specific
check/condition could be added. This is because sometimes people add address
ranges belonging to a VLAN (say vlan://101) instead of vlan://untagged (or
untagged)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
