anuragaw commented on a change in pull request #3575: [WIP DO NOT MERGE] Health
check feature for virtual router
URL: https://github.com/apache/cloudstack/pull/3575#discussion_r358667589
##########
File path:
core/src/main/java/com/cloud/agent/api/routing/SetMonitorServiceCommand.java
##########
@@ -29,21 +32,34 @@
* how to access the components inside the command.
*/
public class SetMonitorServiceCommand extends NetworkElementCommand {
- MonitorServiceTO[] services;
+ public static final String ROUTER_MONITORING_ENABLED =
"router.monitor.enabled";
+ public static final String ROUTER_HEALTH_CHECKS_ENABLED =
"router.health.checks.enabled";
+ public static final String ROUTER_HEALTH_CHECKS_BASIC_INTERVAL =
"router.health.checks.basic.interval";
+ public static final String ROUTER_HEALTH_CHECKS_ADVANCED_INTERVAL =
"router.health.checks.advanced.interval";
+ public static final String ROUTER_HEALTH_CHECKS_EXCLUDED =
"router.health.checks.excluded";
Review comment:
A lot of string config files being passed Daan. I don't think enum is the
solution though. These are keys to access details that I have placed like other
commands did. While not the most efficient way / clean way I don' think we
should be investing more time into this unless we also extend the cleaning
mechanism to the parent class. (Refer NetworkElementCommand.java for instance).
Thoughts?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
