anuragaw commented on a change in pull request #3575: [WIP DO NOT MERGE] Health
check feature for virtual router
URL: https://github.com/apache/cloudstack/pull/3575#discussion_r358708486
##########
File path:
core/src/main/java/com/cloud/agent/resource/virtualnetwork/facade/AbstractConfigItemFacade.java
##########
@@ -127,7 +127,10 @@ private static String appendUuidToJsonFiles(final String
filename) {
final ConfigItem configFile = new
FileConfigItem(VRScripts.CONFIG_PERSIST_LOCATION, remoteFilename,
gson.toJson(configuration));
cfg.add(configFile);
- final ConfigItem updateCommand = new
ScriptConfigItem(VRScripts.UPDATE_CONFIG, remoteFilename);
+ // By default keep files in processed cache on VR
+ final String args = configuration.shouldDeleteFromProcessedCache() ?
remoteFilename + " false" : remoteFilename;
+
+ final ConfigItem updateCommand = new
ScriptConfigItem(VRScripts.UPDATE_CONFIG, args);
Review comment:
This is implemented in a generic fashion. Any command can set the flag
(contained in ConfigBase.deleteFromProcessedCache) to true and the file won't
be saved to processed cache but instead delted AFTER processing. :)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
