anuragaw commented on a change in pull request #3575: [WIP DO NOT MERGE] Health
check feature for virtual router
URL: https://github.com/apache/cloudstack/pull/3575#discussion_r365935167
##########
File path:
server/src/main/java/com/cloud/network/router/VirtualNetworkApplianceManagerImpl.java
##########
@@ -1238,6 +1242,11 @@ protected void runInContext() {
s_logger.info("Found " + routers.size() + " running routers.
Fetching, analysing and updating DB for the health checks.");
for (final DomainRouterVO router : routers) {
+ if
(!RouterHealthChecksEnabled.valueIn(router.getDataCenterId())) {
+ s_logger.debug("Skipping fetching of router health
check results as its disabled for router " + router.getUuid());
+ continue;
+ }
Review comment:
I think we have that covered @DaanHoogland . We log on line 1242 that we are
fetching and analysing results. Then if we are skipping that is logged. Any
subsequent steps are logged as well in sub-methods.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
