anuragaw commented on a change in pull request #3575: [WIP DO NOT MERGE] Health
check feature for virtual router
URL: https://github.com/apache/cloudstack/pull/3575#discussion_r365938750
##########
File path: systemvm/debian/root/health_checks/dhcp_check.py
##########
@@ -41,11 +43,15 @@ def main():
break
if not foundEntry:
- print "Missing elements in dhcphosts.txt - " + entry
- exit(1)
-
- print "All " + str(len(vMs)) + " VMs are present in dhcphosts.txt"
- exit(0)
+ failedCheck = True
+ failureMessage = failureMessage + entry + "\n"
Review comment:
We are appending all failures Daan. The intention is that we want to return
all missing entries so instead of returning on first failure we want to capture
all.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
