anuragaw commented on a change in pull request #3575: [WIP DO NOT MERGE] Health
check feature for virtual router
URL: https://github.com/apache/cloudstack/pull/3575#discussion_r365943592
##########
File path:
server/src/main/java/com/cloud/network/router/VirtualNetworkApplianceManagerImpl.java
##########
@@ -1240,13 +1243,12 @@ protected void runInContext() {
try {
final List<DomainRouterVO> routers =
_routerDao.listByStateAndManagementServer(VirtualMachine.State.Running,
mgmtSrvrId);
s_logger.info("Found " + routers.size() + " running routers.
Fetching, analysing and updating DB for the health checks.");
+ if (!RouterHealthChecksEnabled.value()) {
+ s_logger.debug("Skipping fetching of router health check
results as router.health.checks.enabled is disabled");
+ return;
+ }
Review comment:
I can remove the debug log if you think it's irrelevant? The other paths are
lgged above the if and subsequent subroutines. Thoughts?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
