DaanHoogland commented on a change in pull request #3575: [WIP DO NOT MERGE]
Health check feature for virtual router
URL: https://github.com/apache/cloudstack/pull/3575#discussion_r368550168
##########
File path:
server/src/main/java/com/cloud/network/router/VirtualNetworkApplianceManagerImpl.java
##########
@@ -1290,15 +1285,15 @@ private void handleFailingChecks(DomainRouterVO
router, List<String> failingChec
s_logger.warn(alertMessage + ". Checking failed health checks to
see if router needs reboot");
String checkFailsToRecreateVr =
RouterHealthChecksFailuresToRecreateVr.valueIn(router.getDataCenterId());
- StringBuilder failingChecksEvent = new StringBuilder("Router " +
router.getUuid() + " has failing checks:");
+ StringBuilder failingChecksEvent = new StringBuilder("Router " +
router.getUuid() + " has failing checks: ");
boolean recreateRouter = false;
for (String failedCheck : failingChecks) {
- failingChecksEvent.append(" ").append(failedCheck);
+ failingChecksEvent.append(failedCheck).append(", ");
if (StringUtils.isNotBlank(checkFailsToRecreateVr) &&
checkFailsToRecreateVr.contains(failedCheck)) {
recreateRouter = true;
}
}
-
+ failingChecksEvent.setLength(failingChecksEvent.length() - 2);
Review comment:
this is awkward. Can you append the ", " within the confines of the if?
and maybe make the "Router " + router.getUuid() + " has failing checks: "
conditional on teh first check?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
