DaanHoogland commented on a change in pull request #3575: [WIP DO NOT MERGE]
Health check feature for virtual router
URL: https://github.com/apache/cloudstack/pull/3575#discussion_r365997113
##########
File path:
server/src/main/java/com/cloud/network/router/VirtualNetworkApplianceManagerImpl.java
##########
@@ -1238,6 +1242,11 @@ protected void runInContext() {
s_logger.info("Found " + routers.size() + " running routers.
Fetching, analysing and updating DB for the health checks.");
for (final DomainRouterVO router : routers) {
+ if
(!RouterHealthChecksEnabled.valueIn(router.getDataCenterId())) {
+ s_logger.debug("Skipping fetching of router health
check results as its disabled for router " + router.getUuid());
+ continue;
+ }
Review comment:
don't forget a lot of prod installs have debug enabled. but than again they
should just patch the levels and send PRs in for that ;)
What is it you need (as developer or otherwise) so you want to see this?
I would think if you want to see this you want to see bot enabled and
disabled. You say enabled is covered but those loggings might be missed because
of exceptions.
Also, this is why i kept asking about valueIn(zone). Did you forget to
remove this one?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
