DaanHoogland commented on a change in pull request #3575: [WIP DO NOT MERGE]
Health check feature for virtual router
URL: https://github.com/apache/cloudstack/pull/3575#discussion_r365872428
##########
File path:
server/src/main/java/com/cloud/network/router/VirtualNetworkApplianceManagerImpl.java
##########
@@ -1544,7 +1546,7 @@ private SetMonitorServiceCommand
createMonitorServiceCommand(DomainRouterVO rout
final SetMonitorServiceCommand command = new
SetMonitorServiceCommand(services);
command.setAccessDetail(NetworkElementCommand.ROUTER_IP,
getRouterControlIP(router));
command.setAccessDetail(NetworkElementCommand.ROUTER_NAME,
router.getInstanceName());
-
command.setAccessDetail(SetMonitorServiceCommand.ROUTER_HEALTH_CHECKS_ENABLED,
RouterHealthChecksEnabled.valueIn(router.getDataCenterId()).toString());
+
command.setAccessDetail(SetMonitorServiceCommand.ROUTER_HEALTH_CHECKS_ENABLED,
RouterHealthChecksEnabled.value().toString());
Review comment:
why remove the zone parameter, now that we moved the scope to zone?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
