weizhouapache commented on a change in pull request #3275: [CLOUDSTACK-10408]
Fix String.replaceAll() to replace() for better performance
URL: https://github.com/apache/cloudstack/pull/3275#discussion_r372870422
##########
File path:
framework/ipc/src/main/java/org/apache/cloudstack/framework/serializer/OnwireClassRegistry.java
##########
@@ -109,7 +109,7 @@ public void scan() {
if (filePath != null) {
// WINDOWS HACK
if (filePath.indexOf("%20") > 0)
- filePath = filePath.replaceAll("%20", " ");
Review comment:
we do not have a setup on windows. is it possible there are more than 1
"%20" ?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
