weizhouapache commented on a change in pull request #3275: [CLOUDSTACK-10408]
Fix String.replaceAll() to replace() for better performance
URL: https://github.com/apache/cloudstack/pull/3275#discussion_r372874149
##########
File path:
plugins/hypervisors/vmware/src/main/java/com/cloud/hypervisor/vmware/manager/VmwareStorageManagerImpl.java
##########
@@ -523,7 +523,7 @@ public Answer execute(VmwareHostService hostService,
CreateVolumeFromSnapshotCom
String details = null;
boolean success = false;
- String newVolumeName = UUID.randomUUID().toString().replaceAll("-",
"");
+ String newVolumeName = UUID.randomUUID().toString().replace("-", "");
Review comment:
we need to use replaceAll here.
The UUID contains 4 "-".
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
