Spaceman1984 commented on issue #3873: Fixed root volume resize from ui
URL: https://github.com/apache/cloudstack/pull/3873#issuecomment-584027695
 
 
   > @Spaceman1984
   > I have tested it ,it works.
   > 
   > however, I think we can use the following change on line 1578
   > 
   > ```
   > if (selectedDiskOfferingObj == null || 
selectedDiskOfferingObj.iscustomized == true) {
   > ```
   > 
   > the change on line 1597-1601 are not needed then.
   > 
   > the change on line 1584 are needed.
   @weizhouapache 
   I agree with all, accept, I think line 1601 can be removed, but we need to 
keep line 1597-1600 - it's an error message about not allowing a smaller volume 
size.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

Reply via email to