DaanHoogland commented on a change in pull request #3873: Fixed root volume
resize from ui
URL: https://github.com/apache/cloudstack/pull/3873#discussion_r377482502
##########
File path: ui/scripts/storage.js
##########
@@ -1575,13 +1575,13 @@
if (newDiskOffering != null &&
newDiskOffering.length > 0) {
array1.push("&diskofferingid=" +
encodeURIComponent(newDiskOffering));
}
- if (selectedDiskOfferingObj.iscustomized
== true) {
+ if (selectedDiskOfferingObj == null ||
selectedDiskOfferingObj.iscustomized == true) {
Review comment:
aren't we making an assumption here about the reason the offering is
missing? We only want to allow it if it is missing because it is a root-disk.
It looks like we are allowing some client side hacking; set the
`selectedDiskOfferingObj` to `null` and you are good to go. (i didn't check the
API)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
