GabrielBrascher commented on issue #3903: VR: Send VM password to all Running VRs in network/vpc URL: https://github.com/apache/cloudstack/pull/3903#issuecomment-590293123 Additionally to what I mentioned on the previous comment: `BasicNetworkTopology.applyRules(Network, VirtualRouter, String, boolean, Long, boolean, RuleApplierWrapper<RuleApplier>)` is the method that will return true or false on `savePasswordToRouter`. Most of the issues that can happen there will either raise an exception or log it so I don't see much problem; however, I got interested in the fact that it might make sense to break the loop (and maybe add a log to that explaining). Again, overall it looks OK :)
---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services
