ravening commented on issue #3903: VR: Send VM password to all Running VRs in network/vpc URL: https://github.com/apache/cloudstack/pull/3903#issuecomment-591318066 > > Is it OK to have one of the routers returning false? Would it make sense do break de loop and log an error/warn/debug message? > > @GabrielBrascher good point. if result is false, we can simply log a error message and return false. > @ravening what do you think ? @GabrielBrascher Looked at the code and the function `applyRules` is throwing exception if anything bad happens. So yeah returning false makes sense if it fails for the first router and no need to continue
---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services
