radu-todirica opened a new pull request #3925: Add cache mode param properly URL: https://github.com/apache/cloudstack/pull/3925 ## Description <!--- Describe your changes in detail --> Right now for the createDiskOffering indicates that the cacheMode parameter comes back in the response but there is no equivalent parameter in the request. The following changes have been added: 1. "cacheMode" field has been added to the createServiceOffering endpoint 2. "cacheMode" field has been added to the createDiskOffering endpoint 3. "cacheMode" field will be returned in the listServiceOfferings and listDiskOfferings endpoints. <!-- For new features, provide link to FS, dev ML discussion etc. --> <!-- In case of bug fix, the expected and actual behaviours, steps to reproduce. --> <!-- When "Fixes: #<id>" is specified, the issue/PR will automatically be closed when this PR gets merged --> <!-- For addressing multiple issues/PRs, use multiple "Fixes: #<id>" --> <!-- Fixes: # --> ## Types of changes <!--- What types of changes does your code introduce? Put an `x` in all the boxes that apply: --> - [ ] Breaking change (fix or feature that would cause existing functionality to change) - [x] New feature (non-breaking change which adds functionality) - [ ] Bug fix (non-breaking change which fixes an issue) - [ ] Enhancement (improves an existing feature and functionality) - [ ] Cleanup (Code refactoring and cleanup, that may add test cases) ## Screenshots (if appropriate):     ## How Has This Been Tested? <!-- Please describe in detail how you tested your changes. --> Wrote a python test for testing the creation of service offering with each one of the valid cache mode types : none, writeback and writethrough. Wrote a python test for testing the creation of service offering with invalid cache mode type. [test_service_offerings_results.txt](https://github.com/myENA/cloudstack/files/4252123/test_service_offerings_results.txt) [test_service_offerings_runinfo.txt](https://github.com/myENA/cloudstack/files/4252124/test_service_offerings_runinfo.txt) Wrote a python test for testing the creation of disk offering with each one of the valid cache mode types : none, writeback and writethrough. Wrote a python test for testing the creation of disk offering with invalid cache mode type. [test_disk_offerings_runinfo.txt](https://github.com/myENA/cloudstack/files/4252121/test_disk_offerings_runinfo.txt) [test_disk_offerings_results.txt](https://github.com/myENA/cloudstack/files/4252122/test_disk_offerings_results.txt) <!-- Include details of your testing environment, and the tests you ran to --> <!-- see how your change affects other areas of the code, etc. --> <!-- Please read the [CONTRIBUTING](https://github.com/apache/cloudstack/blob/master/CONTRIBUTING.md) document -->
---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services
