DaanHoogland commented on a change in pull request #3925: Add cache mode param
properly
URL: https://github.com/apache/cloudstack/pull/3925#discussion_r387803550
##########
File path:
api/src/main/java/org/apache/cloudstack/api/command/admin/offering/CreateDiskOfferingCmd.java
##########
@@ -144,6 +144,9 @@
description = "Hypervisor snapshot reserve space as a percent of a
volume (for managed storage using Xen or VMware)")
private Integer hypervisorSnapshotReserve;
+ @Parameter(name = ApiConstants.CACHE_MODE, type = CommandType.STRING,
required = false, description = "the cache mode to use for this disk offering.
none, writeback or writethrough")
Review comment:
@radu-todirica why no since attribute here? no biggy, just wondering if you
forgot.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
