DaanHoogland commented on a change in pull request #3925: Add cache mode param
properly
URL: https://github.com/apache/cloudstack/pull/3925#discussion_r387498637
##########
File path:
api/src/main/java/org/apache/cloudstack/api/response/ServiceOfferingResponse.java
##########
@@ -192,6 +192,10 @@
@Param(description = "is true if the offering is customized", since =
"4.3.0")
private Boolean isCustomized;
+ @SerializedName("cacheMode")
+ @Param(description = "the cache mode to use for this disk offering. none,
writeback or writethrough", since = "4.4")
Review comment:
"since" on the return @Param as attribute but not on the request @Parameter
in the API. Probably C&P as i don't think you are planning this for the 4.4
branch! please adjust and expand (or remove)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
