weizhouapache commented on a change in pull request #3587: vrouter in redundant
mode acquire guest ips from first ip of the tier
URL: https://github.com/apache/cloudstack/pull/3587#discussion_r389349151
##########
File path: server/src/main/java/com/cloud/network/router/NetworkHelperImpl.java
##########
@@ -747,7 +747,7 @@ protected HypervisorType
getClusterToStartDomainRouterForOvm(final long podId) {
final NicProfile gatewayNic = new
NicProfile(defaultNetworkStartIp, defaultNetworkStartIpv6);
if (routerDeploymentDefinition.isPublicNetwork()) {
if (routerDeploymentDefinition.isRedundant()) {
-
gatewayNic.setIPv4Address(_ipAddrMgr.acquireGuestIpAddress(guestNetwork, null));
+
gatewayNic.setIPv4Address(_ipAddrMgr.acquireFirstGuestIpAddress(guestNetwork));
Review comment:
@ArthurHlt should acquireGuestIpAddressForVrouterRedundant be used here ?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
