weizhouapache commented on a change in pull request #3587: vrouter in redundant
mode acquire guest ips from first ip of the tier
URL: https://github.com/apache/cloudstack/pull/3587#discussion_r390869137
##########
File path:
engine/components-api/src/main/java/com/cloud/network/IpAddressManager.java
##########
@@ -103,6 +103,12 @@ boolean applyIpAssociations(Network network, boolean
rulesRevoked, boolean conti
String acquireGuestIpAddress(Network network, String requestedIp);
+ String acquireFirstGuestIpAddress(Network network);
+
+ String acquireLastGuestIpAddress(Network network);
+
+ String acquireGuestIpAddressByPlacement(IpPlacement ipPlacement, Network
network, String requestedIp);
Review comment:
@ArthurHlt maybe you use create new public method without ipPlacement.
```
String acquireGuestIpAddressByPlacement(Network network, String requestedIp);
```
VrouterRedundantTiersPlacement can also be moved to IpAddressManager instead
of GuestNetworkGuru
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
