DaanHoogland commented on a change in pull request #3976: Enable sending
hypervior host name via metadata - VR and Config Drive
URL: https://github.com/apache/cloudstack/pull/3976#discussion_r399267259
##########
File path:
engine/orchestration/src/main/java/org/apache/cloudstack/engine/orchestration/NetworkOrchestrator.java
##########
@@ -1610,6 +1612,26 @@ public void finalizeUpdateInSequence(Network network,
boolean success) {
}
}
+ @Override
+ public void addNewDisk(VirtualMachineProfile vm, DeployDestination dest)
throws ResourceUnavailableException {
Review comment:
in view of what this method does, the name "addNewDisk" seems completely
wrong. Why is it named like this?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
