DaanHoogland commented on a change in pull request #3976: Enable sending
hypervior host name via metadata - VR and Config Drive
URL: https://github.com/apache/cloudstack/pull/3976#discussion_r399255992
##########
File path: engine/api/src/main/java/com/cloud/vm/VirtualMachineManager.java
##########
@@ -61,6 +61,12 @@
ConfigKey<Boolean> ResoureCountRunningVMsonly = new
ConfigKey<Boolean>("Advanced", Boolean.class,
"resource.count.running.vms.only", "false",
"Count the resources of only running VMs in resource limitation.",
true);
+ ConfigKey<Boolean> AllowExposeHypervisorHostnameAccoutLevel = new
ConfigKey<Boolean>("Advanced", Boolean.class, "allow.expose.host.hostname",
Review comment:
also, I know this was countered before, but I woud like to see account in
the name of this setting. i.e. "account.allow.expose.host.hostname" and
"general.allow.expose.host.hostname"
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
