DaanHoogland commented on a change in pull request #3976: Enable sending
hypervior host name via metadata - VR and Config Drive
URL: https://github.com/apache/cloudstack/pull/3976#discussion_r399272418
##########
File path:
engine/api/src/main/java/org/apache/cloudstack/engine/orchestration/service/NetworkOrchestrationService.java
##########
@@ -294,6 +294,8 @@ void
implementNetworkElementsAndResources(DeployDestination dest, ReservationCon
void finalizeUpdateInSequence(Network network, boolean success);
+ void addNewDisk(VirtualMachineProfile vm, DeployDestination dest) throws
ResourceUnavailableException;
Review comment:
please add javadoc. the purpose of this method is not obvious from the name,
parameters or return type.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
