sureshanaparti commented on a change in pull request #4071:
URL: https://github.com/apache/cloudstack/pull/4071#discussion_r433398348
##########
File path:
api/src/main/java/org/apache/cloudstack/api/command/admin/acl/RoleCmd.java
##########
@@ -18,11 +18,41 @@
package org.apache.cloudstack.api.command.admin.acl;
import org.apache.cloudstack.acl.Role;
+import org.apache.cloudstack.acl.RoleType;
+import org.apache.cloudstack.api.ApiConstants;
import org.apache.cloudstack.api.BaseCmd;
+import org.apache.cloudstack.api.Parameter;
import org.apache.cloudstack.api.response.RoleResponse;
+import com.google.common.base.Strings;
+
public abstract class RoleCmd extends BaseCmd {
+ /////////////////////////////////////////////////////
+ //////////////// API parameters /////////////////////
+ /////////////////////////////////////////////////////
+
+ @Parameter(name = ApiConstants.TYPE, type = CommandType.STRING,
description = "The type of the role, valid options are: Admin, ResourceAdmin,
DomainAdmin, User")
+ private String roleType;
Review comment:
> I get the reuse with the createRole API, but do we want these
parameters for the updateRole API?
yep, UpdateRoleCmd also inherits the same RoleCmd.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
