sureshanaparti commented on a change in pull request #4071:
URL: https://github.com/apache/cloudstack/pull/4071#discussion_r433404787
##########
File path: server/src/main/java/org/apache/cloudstack/acl/RoleManagerImpl.java
##########
@@ -159,9 +242,6 @@ public Role updateRole(final Role role, final String name,
final RoleType roleTy
roleVO.setName(name);
}
if (roleType != null) {
- if (role.getId() <= RoleType.User.getId()) {
Review comment:
@rhtyd agree that the role ids are compared against the role type enum
earlier. now these roles, with ids (1,2,3,4) are marked as default roles, which
is considered while updating or deleting the role. The `role` is already
populated with db details.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
