DaanHoogland commented on a change in pull request #4329:
URL: https://github.com/apache/cloudstack/pull/4329#discussion_r514204713
##########
File path:
plugins/integrations/kubernetes-service/src/main/java/com/cloud/kubernetes/cluster/actionworkers/KubernetesClusterStartWorker.java
##########
@@ -378,17 +376,18 @@ private void setupKubernetesClusterNetworkRules(Network
network, List<UserVm> cl
throw new ManagementServerException(String.format("No source NAT
IP addresses found for network : %s, Kubernetes cluster : %s",
network.getName(), kubernetesCluster.getName()));
}
-
+ // Firewall rule fo API access for master node VMs
try {
provisionFirewallRules(publicIp, owner, CLUSTER_API_PORT,
CLUSTER_API_PORT);
if (LOGGER.isInfoEnabled()) {
- LOGGER.info(String.format("Provisioned firewall rule to open
up port %d on %s for Kubernetes cluster ID: %s",
- CLUSTER_API_PORT, publicIp.getAddress().addr(),
kubernetesCluster.getUuid()));
+ LOGGER.info(String.format("Provisioned firewall rule to open
up port %d on %s for Kubernetes cluster %s",
+ CLUSTER_API_PORT, publicIp.getAddress().addr(),
kubernetesCluster.getName()));
}
} catch (NoSuchFieldException | IllegalAccessException |
ResourceUnavailableException | NetworkRuleConflictException e) {
throw new ManagementServerException(String.format("Failed to
provision firewall rules for API access for the Kubernetes cluster : %s",
kubernetesCluster.getName()), e);
}
+ // Firewall rule fo SSH access on each node VM
Review comment:
idem; this comment could be a method name and the bit below factored out
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
